hkoosha opened a new pull request #3072:
URL: https://github.com/apache/incubator-gobblin/pull/3072
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1226
### Description
Lombok is a cool tool (although IMHO not worth it's troubles, considering
generated code is harder to debug, incompatibilities in bytecode, line version
mismatch in debugger, etc, etc) which promises to have zero runtime
dependencies.
It is also strongly advised by its developers that it should be present on
the classpath only during compilation/code generation and not at all, during
runtime. (I don't have an exact reference at hand but it can be searched in the
lombok google forum).
Lombok in runtime's classpath is considered not only a bad practice but
wrong usage of lombok.
The issue it caused me was that it brings an older version of guava into
path.
I propose the `compile ...lombok` in `build.gradle` be changed to
`compileOnly`. This has zero effects on any current project using gobblin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
