hkoosha commented on pull request #3072:
URL:
https://github.com/apache/incubator-gobblin/pull/3072#issuecomment-675314005
Well, one problem could be that lombok may liberally use any dependency as
they wish, no matter how outdated. Then including lombok in Gobblin's runtime
means needlessly pulling those transitive dependencies into classpath.
Why needlessly? because one of lombok promises is: zero runtime dependency.
No code path within lombok is accessed during runtime. No other third-party
library is used within lombok's generated code either. The generated code is
just pure vanilla java.
All those lombok annotations we add to the code, and lombok.* package
references are all removed during AST transformation.
So why include it's jar and its transitive dependencies at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
