autumnust commented on a change in pull request #3092:
URL: https://github.com/apache/incubator-gobblin/pull/3092#discussion_r478704131
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTaskStateTracker.java
##########
@@ -59,7 +58,11 @@ public void registerNewTask(Task task) {
try {
this.scheduledReporters.put(task.getTaskId(),
scheduleTaskMetricsUpdater(new TaskMetricsUpdater(task), task));
} catch (RejectedExecutionException ree) {
+ // Propagate the exception to caller that has full control of the
life-cycle of a helix task.
LOGGER.error(String.format("Scheduling of task state reporter for task
%s was rejected", task.getTaskId()));
+ Throwables.propagate(ree);
Review comment:
addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
