sv2000 commented on a change in pull request #3092:
URL: https://github.com/apache/incubator-gobblin/pull/3092#discussion_r478716594
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTaskStateTracker.java
##########
@@ -42,24 +45,39 @@
*
* @author Yinan Li
*/
-@Alpha
+@Slf4j
public class GobblinHelixTaskStateTracker extends AbstractTaskStateTracker {
-
- private static final Logger LOGGER =
LoggerFactory.getLogger(GobblinHelixTaskStateTracker.class);
+ @VisibleForTesting
+ static final String IS_TASK_METRICS_SCHEDULING_FAILURE_FATAl =
"helixTaskTracker.isNewTaskRegFailureFatal";
Review comment:
FATAl -> FATAL.
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTaskStateTracker.java
##########
@@ -42,24 +45,39 @@
*
* @author Yinan Li
*/
-@Alpha
+@Slf4j
public class GobblinHelixTaskStateTracker extends AbstractTaskStateTracker {
-
- private static final Logger LOGGER =
LoggerFactory.getLogger(GobblinHelixTaskStateTracker.class);
+ @VisibleForTesting
+ static final String IS_TASK_METRICS_SCHEDULING_FAILURE_FATAl =
"helixTaskTracker.isNewTaskRegFailureFatal";
+ private static final String DEFAULT_TASK_METRICS_SCHEDULING_FAILURE_FATAl =
"false";
Review comment:
FATAl -> FATAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
