[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3138: [GOBBLIN-1300] Rethrow exceptions when storing job status in state store

[GitBox]

sv2000 commented on a change in pull request #3138:
URL: https://github.com/apache/incubator-gobblin/pull/3138#discussion_r511167846



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -134,6 +134,8 @@ protected void 
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
       if (jobStatus != null) {
         try(Timer.Context context = 
getMetricContext().timer(GET_AND_SET_JOB_STATUS).time()) {
           addJobStatusToStateStore(jobStatus, this.stateStore);
+        } catch (IOException ioe) {
+          throw new RuntimeException("Failed to add job status to state 
store", ioe);

Review comment:
       parseJobStatus method can be modified to swallow the IOException. It 
seems to be doing that for most part anyways. The IOException being thrown by 
readSchemaVersioningInformation can be caught inside the method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org