[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3138: [GOBBLIN-1300] Rethrow exceptions when storing job status in state store

[GitBox]

sv2000 commented on a change in pull request #3138:
URL: https://github.com/apache/incubator-gobblin/pull/3138#discussion_r511174687



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaAvroJobStatusMonitor.java
##########
@@ -86,10 +87,15 @@ protected void createMetrics() {
   }
 
   @Override
-  public org.apache.gobblin.configuration.State parseJobStatus(byte[] message)
-      throws IOException {
+  public org.apache.gobblin.configuration.State parseJobStatus(byte[] message) 
{
     InputStream is = new ByteArrayInputStream(message);
-    schemaVersionWriter.readSchemaVersioningInformation(new 
DataInputStream(is));
+    try {

Review comment:
       Can we merge the two try..catch blocks into one? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org