[
https://issues.apache.org/jira/browse/GOBBLIN-1316?focusedWorklogId=510563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510563
]
ASF GitHub Bot logged work on GOBBLIN-1316:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/20 02:05
Start Date: 12/Nov/20 02:05
Worklog Time Spent: 10m
Work Description: htran1 commented on a change in pull request #3153:
URL: https://github.com/apache/incubator-gobblin/pull/3153#discussion_r521770998
##########
File path:
gobblin-utility/src/test/java/org/apache/gobblin/util/AvroUtilsTest.java
##########
@@ -51,9 +51,11 @@
import org.codehaus.jackson.JsonNode;
import org.codehaus.jackson.map.ObjectMapper;
import org.codehaus.jackson.node.ArrayNode;
+import org.codehaus.jackson.node.JsonNodeFactory;
import org.testng.Assert;
import org.testng.annotations.Test;
+import com.beust.jcommander.internal.Lists;
Review comment:
Should this be the guava one instead?
##########
File path:
gobblin-utility/src/test/java/org/apache/gobblin/util/AvroUtilsTest.java
##########
@@ -235,8 +237,21 @@ public void testSwitchNamespace() {
String originalNamespace = "originalNamespace";
String originalName = "originalName";
String newNamespace = "newNamespace";
- Schema schema =
SchemaBuilder.builder(originalNamespace).record(originalName).fields().
- requiredDouble("double").optionalFloat("float").endRecord();
+ //Schema schema =
SchemaBuilder.builder(originalNamespace).record(originalName).fields().
Review comment:
Remove these lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 510563)
Time Spent: 20m (was: 10m)
> Copy field and schema level properties when switching namespace in a schema
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1316
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1316
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: misc
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a namespace override is applied to an input schema, the new schema does
> not currently contain the field and schema level properties of the original
> schema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
