[
https://issues.apache.org/jira/browse/GOBBLIN-1316?focusedWorklogId=513893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-513893
]
ASF GitHub Bot logged work on GOBBLIN-1316:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/20 01:25
Start Date: 19/Nov/20 01:25
Worklog Time Spent: 10m
Work Description: shirshanka commented on a change in pull request #3153:
URL: https://github.com/apache/incubator-gobblin/pull/3153#discussion_r526531121
##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java
##########
@@ -781,11 +781,19 @@ public static Schema switchNamespace(Schema schema,
Map<String, String> namespac
for (Schema.Field oldField : schema.getFields()) {
Field newField = new Field(oldField.name(),
switchNamespace(oldField.schema(), namespaceOverride), oldField.doc(),
oldField.defaultValue(), oldField.order());
+ // Copy field level properties
+ for (Map.Entry<String, JsonNode> prop :
oldField.getJsonProps().entrySet()) {
Review comment:
Use the already defined copyFieldProperties method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 513893)
Time Spent: 0.5h (was: 20m)
> Copy field and schema level properties when switching namespace in a schema
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1316
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1316
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: misc
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When a namespace override is applied to an input schema, the new schema does
> not currently contain the field and schema level properties of the original
> schema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
