[
https://issues.apache.org/jira/browse/GOBBLIN-1319?focusedWorklogId=515324&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515324
]
ASF GitHub Bot logged work on GOBBLIN-1319:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/20 22:31
Start Date: 22/Nov/20 22:31
Worklog Time Spent: 10m
Work Description: arjun4084346 opened a new pull request #3155:
URL: https://github.com/apache/incubator-gobblin/pull/3155
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
@yukuai518 please review
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1319
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
- jobsMapping in GobblinHelixJobScheduler was using job name to store the
mapping of job to planning/actual job. this pr is changing it to use job uri
instead, because cancellation request just have a uri
- provide a clean separate path for cancellation on cluster side, so that
'delete' calls from within the cluster and from gobblin service can be treated
differently
- storing non distributed mode jobs also in JobsMapping in order to provide
a cleaner control over cancellation. Storing helix jobs' metadata in a mysql
table will also let users cancel the flow if cluster-manager restarts after
initial flow submission.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
verified with integration test
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 515324)
Time Spent: 1h (was: 50m)
> fix helix job cancellation in gobblin cluster
> ---------------------------------------------
>
> Key: GOBBLIN-1319
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1319
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
