[
https://issues.apache.org/jira/browse/GOBBLIN-1319?focusedWorklogId=515670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515670
]
ASF GitHub Bot logged work on GOBBLIN-1319:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/20 17:25
Start Date: 23/Nov/20 17:25
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3155:
URL: https://github.com/apache/incubator-gobblin/pull/3155#discussion_r528873754
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallable.java
##########
@@ -196,22 +202,57 @@ private void deleteJobSpec() throws JobException {
* the job launcher determines it is safe to stop.
*/
private void runJobLauncherLoop() throws JobException {
+ String actualJobId;
+ Lock jobLock = locks.get(this.jobUri);
Review comment:
It is to avoid race condition in checking if the job with the same name
is running. this is a new thing this method is doing.
reference
https://github.com/apache/incubator-gobblin/blob/master/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallable.java#L240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 515670)
Time Spent: 2h 20m (was: 2h 10m)
> fix helix job cancellation in gobblin cluster
> ---------------------------------------------
>
> Key: GOBBLIN-1319
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1319
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
