[
https://issues.apache.org/jira/browse/GOBBLIN-1319?focusedWorklogId=516514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-516514
]
ASF GitHub Bot logged work on GOBBLIN-1319:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/20 07:51
Start Date: 25/Nov/20 07:51
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3155:
URL: https://github.com/apache/incubator-gobblin/pull/3155#discussion_r530166558
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -367,6 +369,42 @@ public void
handleDeleteJobConfigArrival(DeleteJobConfigArrivalEvent deleteJobAr
}
}
+ @Subscribe
+ public void handleCancelJobConfigArrival(CancelJobConfigArrivalEvent
cancelJobArrival)
+ throws InterruptedException {
+ String jobUri = cancelJobArrival.getJoburi();
+ LOGGER.info("Received cancel for job configuration of job " + jobUri);
+ Optional<String> distributedJobMode;
+ Optional<String> planningJob = Optional.empty();
+ Optional<String> actualJob = Optional.empty();
+
+ this.jobSchedulerMetrics.numCancellationStart.incrementAndGet();
+
+ try {
+ distributedJobMode = this.jobsMapping.getDistributedJobMode(jobUri);
+ if (distributedJobMode.isPresent() &&
Boolean.parseBoolean(distributedJobMode.get())) {
+ planningJob = this.jobsMapping.getPlanningJobId(jobUri);
Review comment:
Yes, because the planning job cancellation method cancels the actual job.
https://github.com/apache/incubator-gobblin/blob/master/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java#L256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 516514)
Time Spent: 3h 20m (was: 3h 10m)
> fix helix job cancellation in gobblin cluster
> ---------------------------------------------
>
> Key: GOBBLIN-1319
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1319
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
