[
https://issues.apache.org/jira/browse/GOBBLIN-1348?focusedWorklogId=530105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530105
]
ASF GitHub Bot logged work on GOBBLIN-1348:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/21 01:43
Start Date: 02/Jan/21 01:43
Worklog Time Spent: 10m
Work Description: abti commented on a change in pull request #3187:
URL: https://github.com/apache/incubator-gobblin/pull/3187#discussion_r550829755
##########
File path: .github/workflows/docker_build_publish.yaml
##########
@@ -21,44 +21,60 @@ on:
# Publish only on `master`
branches:
- master
-
+ pull_request:
Review comment:
If I understand this correctly, it will trigger the build and push at
each pull request creation rather than when a commit is pushed? That would be
quite a few docker images with unreviewed code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530105)
Time Spent: 0.5h (was: 20m)
> Github actions fails due to restriction to only verified actions
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1348
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1348
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Repository settings were changed so that non-verified github actions or
> non-apache actions could not be run in workflows. The docker metadata tag
> generation uses one of these, so it must be done manually instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
