[
https://issues.apache.org/jira/browse/GOBBLIN-1348?focusedWorklogId=530106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530106
]
ASF GitHub Bot logged work on GOBBLIN-1348:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/21 01:48
Start Date: 02/Jan/21 01:48
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3187:
URL: https://github.com/apache/incubator-gobblin/pull/3187#discussion_r550830367
##########
File path: .github/workflows/docker_build_publish.yaml
##########
@@ -21,44 +21,60 @@ on:
# Publish only on `master`
branches:
- master
-
+ pull_request:
Review comment:
It'll trigger the build whenever there is a push on master, when there
is a new release or when there is a new pull request against master (and
anytime that branch is updated after the PR is created)
In the build and push action I prevent pushing to the repository if the
event is a pull request, so it should only be used to check if the docker file
modifications/github actions modifications are valid without creating a new
image on dockerhub.
Also it should only be triggering the CI if the PR includes a file that
modifies the docker file or the github action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530106)
Time Spent: 40m (was: 0.5h)
> Github actions fails due to restriction to only verified actions
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1348
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1348
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Repository settings were changed so that non-verified github actions or
> non-apache actions could not be run in workflows. The docker metadata tag
> generation uses one of these, so it must be done manually instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
