[
https://issues.apache.org/jira/browse/GOBBLIN-1352?focusedWorklogId=532168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532168
]
ASF GitHub Bot logged work on GOBBLIN-1352:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 22:29
Start Date: 06/Jan/21 22:29
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3191:
URL: https://github.com/apache/incubator-gobblin/pull/3191#discussion_r552993956
##########
File path:
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallableTest.java
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.cluster;
+
+import java.io.File;
+import java.util.Optional;
+import java.util.Properties;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.helix.HelixManager;
+import org.assertj.core.util.Lists;
+import org.junit.Assert;
+import org.mockito.Mockito;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+import com.typesafe.config.ConfigValueFactory;
+
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.runtime.api.MutableJobCatalog;
+import org.apache.gobblin.runtime.job_catalog.NonObservingFSJobCatalog;
+import org.apache.gobblin.scheduler.SchedulerService;
+
+
+public class HelixRetriggeringJobCallableTest {
+ public static final String TMP_DIR = "/tmp/" +
HelixRetriggeringJobCallable.class.getSimpleName();
+
+ @BeforeClass
+ public void setUp() {
+ File tmpDir = new File(TMP_DIR);
+ if (!tmpDir.exists()) {
+ tmpDir.mkdirs();
+ }
+ tmpDir.deleteOnExit();
+ }
+
+ @Test
+ public void testBuildJobLauncher()
+ throws Exception {
+ Config config =
ConfigFactory.empty().withValue(ConfigurationKeys.JOB_CONFIG_FILE_GENERAL_PATH_KEY,
+ ConfigValueFactory.fromAnyRef(TMP_DIR));
+ MutableJobCatalog jobCatalog = new NonObservingFSJobCatalog(config);
+ SchedulerService schedulerService = new SchedulerService(new Properties());
+ //HelixManager helixManager = Mockito.mock(HelixManager.class);
Review comment:
Shall we remove these lines ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532168)
Time Spent: 0.5h (was: 20m)
> Ensure Helix workflows are cleaned up on cluster start up in centralized mode
> -----------------------------------------------------------------------------
>
> Key: GOBBLIN-1352
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1352
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of the changes introduced in GOBBLIN-1319, the Helix workflow names
> were modified to include a special prefix. However, this prefix is intended
> for use in distributed mode. As a consequence of this change, the workflows
> are no longer being cleaned up on cluster start up leading to a leak in
> Znodes. Further, since the workflows are left in the START state, the Yarn
> autoscaling manager requests more containers than needed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
