[
https://issues.apache.org/jira/browse/GOBBLIN-1352?focusedWorklogId=532278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532278
]
ASF GitHub Bot logged work on GOBBLIN-1352:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/21 05:45
Start Date: 07/Jan/21 05:45
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3191:
URL:
https://github.com/apache/incubator-gobblin/pull/3191#issuecomment-755898981
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3191?src=pr&el=h1)
Report
> Merging
[#3191](https://codecov.io/gh/apache/incubator-gobblin/pull/3191?src=pr&el=desc)
(480f796) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/b1006b4da3f036cffdb81978faf3f26f3e577f76?el=desc)
(b1006b4) will **decrease** coverage by `37.07%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3191?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3191 +/- ##
============================================
- Coverage 46.18% 9.11% -37.08%
+ Complexity 9753 1726 -8027
============================================
Files 2014 2017 +3
Lines 77095 77211 +116
Branches 8559 8566 +7
============================================
- Hits 35606 7035 -28571
- Misses 38182 69488 +31306
+ Partials 3307 688 -2619
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3191?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh)
| `0.00% <0.00%> (-60.63%)` | `0.00 <0.00> (-10.00)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
|
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/cluster/SingleHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlSGVsaXhUYXNrLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1067
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3191/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3191?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3191?src=pr&el=footer).
Last update
[b1006b4...480f796](https://codecov.io/gh/apache/incubator-gobblin/pull/3191?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532278)
Time Spent: 40m (was: 0.5h)
> Ensure Helix workflows are cleaned up on cluster start up in centralized mode
> -----------------------------------------------------------------------------
>
> Key: GOBBLIN-1352
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1352
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As part of the changes introduced in GOBBLIN-1319, the Helix workflow names
> were modified to include a special prefix. However, this prefix is intended
> for use in distributed mode. As a consequence of this change, the workflows
> are no longer being cleaned up on cluster start up leading to a leak in
> Znodes. Further, since the workflows are left in the START state, the Yarn
> autoscaling manager requests more containers than needed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
