[
https://issues.apache.org/jira/browse/GOBBLIN-1359?focusedWorklogId=535862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-535862
]
ASF GitHub Bot logged work on GOBBLIN-1359:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/21 04:13
Start Date: 14/Jan/21 04:13
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3200:
URL: https://github.com/apache/incubator-gobblin/pull/3200#discussion_r557032962
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -227,7 +227,10 @@ public void
consumeRecordStream(RecordStreamWithMetadata<D, S> stream)
r.ack();
}
- }, e -> logger.error("Failed to process record.", e),
+ }, e -> {
+ logger.error("Failed to process record.", e);
+ throw((Exception) e);
Review comment:
Sorry - I did not realize earlier that e is a throwable, in which case I
now understand why you had to wrap it into a RuntimeException. I think that
would be better than casting to an Exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 535862)
Time Spent: 50m (was: 40m)
> Fix the error that IOException thrown by writer be swallowed by Reactivex
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1359
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1359
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> we have a bug in Reactivex code which swallows the exception and leaves the
> task hanging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
