[
https://issues.apache.org/jira/browse/GOBBLIN-1359?focusedWorklogId=542489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542489
]
ASF GitHub Bot logged work on GOBBLIN-1359:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 22:49
Start Date: 26/Jan/21 22:49
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3214:
URL: https://github.com/apache/incubator-gobblin/pull/3214#discussion_r564888071
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -229,7 +229,7 @@ public void consumeRecordStream(RecordStreamWithMetadata<D,
S> stream)
}
}, e -> {
logger.error("Failed to process record.", e);
- throw(new RuntimeException(e));
+ verifyAndSetForkState(ForkState.RUNNING, ForkState.FAILED);
Review comment:
writer close is handled in the doFinal() part. It will be executed when
the subscription is finished either by error or complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 542489)
Time Spent: 2h 20m (was: 2h 10m)
> Fix the error that IOException thrown by writer be swallowed by Reactivex
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1359
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1359
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> we have a bug in Reactivex code which swallows the exception and leaves the
> task hanging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
