[
https://issues.apache.org/jira/browse/GOBBLIN-1372?focusedWorklogId=541425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-541425
]
ASF GitHub Bot logged work on GOBBLIN-1372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 01:22
Start Date: 26/Jan/21 01:22
Worklog Time Spent: 10m
Work Description: autumnust opened a new pull request #3213:
URL: https://github.com/apache/incubator-gobblin/pull/3213
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
https://issues.apache.org/jira/browse/GOBBLIN-1372
### Description
This PR mainly is for refactoring the method
`GobblinClusterUtils#setSystemProperties`. The problem was: There are some
unnecessary details being exposed: `JAVA_TMP_DIR_KEY` and resolution of
`YARN_CACHE` are all very specific to Gobblin-on-YARN applications. These
things shouldn't be set through if-branch but through configurations only.
After refactoring:
There's no specific key/value matching within `setSystemProperties` method,
and we don't lose the capability for limiting resolution of `YARN_CACHE` only
for a specific set of configuration with being backward-compatible.
Also, the refactor also let the program to set additional configuration with
value specified as `YARN_CACHE` using the following pairs:
```
gobblin.cluster.systemPropertiesList.YARN_CACHE=grape.root
gobblin.cluster.sysProps.grape.root=YARN_CACHE
```
If trying to achieve the same purpose as `-Dgrape.root=YARN_CACHE`
Also, it adds a bunch of entries in the .gitignore file.
### Tests
Unit tested with resolution cases.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 541425)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor runtime-jvm argument setting
> -------------------------------------
>
> Key: GOBBLIN-1372
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1372
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
