[
https://issues.apache.org/jira/browse/GOBBLIN-1372?focusedWorklogId=541994&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-541994
]
ASF GitHub Bot logged work on GOBBLIN-1372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 04:45
Start Date: 26/Jan/21 04:45
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3213:
URL:
https://github.com/apache/incubator-gobblin/pull/3213#issuecomment-767291856
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=h1)
Report
> Merging
[#3213](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=desc)
(6a263e7) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/f4c75139bf38b73b3fc052cc5c2010cdca9bc4c0?el=desc)
(f4c7513) will **increase** coverage by `32.72%`.
> The diff coverage is `92.30%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3213 +/- ##
=============================================
+ Coverage 9.17% 41.89% +32.72%
- Complexity 1738 8908 +7170
=============================================
Files 2019 2019
Lines 77506 77524 +18
Branches 8607 8610 +3
=============================================
+ Hits 7109 32477 +25368
+ Misses 69701 41985 -27716
- Partials 696 3062 +2366
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...rg/apache/gobblin/cluster/GobblinClusterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJVdGlscy5qYXZh)
| `87.03% <92.30%> (+34.25%)` | `13.00 <5.00> (+4.00)` | |
|
[.../org/apache/gobblin/util/filters/HiddenFilter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsdGVycy9IaWRkZW5GaWx0ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
|
[...g/apache/gobblin/cluster/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[.../gobblin/compaction/suite/CompactionSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZS5qYXZh)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
|
[...obblin/compaction/source/CompactionFailedTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc291cmNlL0NvbXBhY3Rpb25GYWlsZWRUYXNrLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/cluster/event/ClusterManagerShutdownRequest.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2x1c3Rlck1hbmFnZXJTaHV0ZG93blJlcXVlc3QuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...blin/compaction/mapreduce/RecordKeyMapperBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL1JlY29yZEtleU1hcHBlckJhc2UuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...in/compaction/action/CompactionCompleteAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25Db21wbGV0ZUFjdGlvbi5qYXZh)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...n/compaction/mapreduce/orc/OrcKeyDedupReducer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNLZXlEZWR1cFJlZHVjZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [1176
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=footer).
Last update
[f4c7513...6a263e7](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 541994)
Time Spent: 50m (was: 40m)
> Refactor runtime-jvm argument setting
> -------------------------------------
>
> Key: GOBBLIN-1372
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1372
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
