sv2000 commented on a change in pull request #3214:
URL: https://github.com/apache/incubator-gobblin/pull/3214#discussion_r564877757
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -229,7 +229,7 @@ public void consumeRecordStream(RecordStreamWithMetadata<D,
S> stream)
}
}, e -> {
logger.error("Failed to process record.", e);
- throw(new RuntimeException(e));
+ verifyAndSetForkState(ForkState.RUNNING, ForkState.FAILED);
Review comment:
Does the writer need to be closed or will it be taken care of as part of
shutdown sequence?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
