ZihanLi58 commented on a change in pull request #3214:
URL: https://github.com/apache/incubator-gobblin/pull/3214#discussion_r565722354
##########
File path:
gobblin-core-base/src/main/java/org/apache/gobblin/source/extractor/extract/FlushingExtractor.java
##########
@@ -298,6 +298,14 @@ protected void publishTaskOutput() throws IOException {
this.flushPublisher.get().publish(Collections.singletonList(workUnitState));
}
+ @Override
+ public void shutdown() {
Review comment:
Yeah, it's a newly added method which will be called in
kafkaStreamingExtractor.shutdown(), and the kafkaStreamingExtractor.shutdown()
method did not call super.shutdown(), so I did not add it here as well. Also
super.shutdown is meaning to check it's a decorator, which is not applied to
this case as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
