[
https://issues.apache.org/jira/browse/GOBBLIN-1359?focusedWorklogId=543201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543201
]
ASF GitHub Bot logged work on GOBBLIN-1359:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 23:53
Start Date: 27/Jan/21 23:53
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3214:
URL: https://github.com/apache/incubator-gobblin/pull/3214#discussion_r565722354
##########
File path:
gobblin-core-base/src/main/java/org/apache/gobblin/source/extractor/extract/FlushingExtractor.java
##########
@@ -298,6 +298,14 @@ protected void publishTaskOutput() throws IOException {
this.flushPublisher.get().publish(Collections.singletonList(workUnitState));
}
+ @Override
+ public void shutdown() {
Review comment:
Yeah, it's a newly added method which will be called in
kafkaStreamingExtractor.shutdown(), and the kafkaStreamingExtractor.shutdown()
method did not call super.shutdown(), so I did not add it here as well. Also
super.shutdown is meaning to check it's a decorator, which is not applied to
this case as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543201)
Time Spent: 3h 20m (was: 3h 10m)
> Fix the error that IOException thrown by writer be swallowed by Reactivex
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1359
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1359
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> we have a bug in Reactivex code which swallows the exception and leaves the
> task hanging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
