jack-moseley opened a new pull request #3238: URL: https://github.com/apache/gobblin/pull/3238
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1402 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): Make it possible to update the owner/requester list in a FlowConfig in some circumstances, and also refactoring/fixing some other related issues. - In `FlowConfigResourceLocalHandler`, don't overwrite the previous requester list property (to allow it to be updated if it was specified by a user) - Move whitelisted requester checking to an API in `RequesterService` to allow it to be used by handlers - Add some checks to deprecated "flowconfigs" endpoint, since it was possible to set owning group to a group you were not part of through that endpoint - Add checks as well to "flowconfigsV2" endpoint to avoid a similar way of updating the owning group, and to include the logic for when requester list is allowed to be updated ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Updated unit tests and tested locally ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
