jack-moseley commented on a change in pull request #3238:
URL: https://github.com/apache/gobblin/pull/3238#discussion_r586835857
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
##########
@@ -301,6 +302,42 @@ public void testLocalGroupOwnershipUpdates() throws
Exception {
_client.deleteFlowConfig(new
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_7));
}
+
+ @Test (expectedExceptions = RestLiResponseException.class)
Review comment:
Doesn't this have the issue that the test will pass if no exception is
thrown? (Unless you do something like `throw new RuntimeException("Shouldn't
reach here")` after the point you expect it to fail). Probably better to use
the `expectedExceptionsMessageRegExp` mentioned by Alex above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
