jack-moseley commented on a change in pull request #3238:
URL: https://github.com/apache/gobblin/pull/3238#discussion_r587826887
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
##########
@@ -262,7 +265,7 @@ public void testGroupRequesterRejected() throws Exception {
}
}
- @Test
+ @Test(dependsOnMethods = {"testGroupRequesterRejected",
"testGroupRequesterAllowed", "testGroupUpdateRejected", "testRequesterUpdate"})
Review comment:
I couldn't think of a good way since it is modifying files that were
used by other tests in the same class (this could have been a problem even
before this PR).
I decided to refactor and move this test to a separate class. I'm not sure
why it was even in this class in the first place, since it seems to be testing
that `LocalGroupOwnershipService` is able to pick up changes to the file, which
is unrelated to flowConfig client. (And in this class there is already tests
that group ownership is working while calling flowConfig client).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
