Will-Lo commented on a change in pull request #3158:
URL: https://github.com/apache/gobblin/pull/3158#discussion_r589815917
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/JobLauncherUtils.java
##########
@@ -197,6 +197,14 @@ public static void cleanTaskStagingData(State state,
Logger logger) throws IOExc
throw new IOException("Clean up output directory " +
outputPath.toUri().getPath() + " failed");
}
}
+
+ Path errPath = new
Path(state.getProp(ConfigurationKeys.ROW_LEVEL_ERR_FILE));
Review comment:
The error file is specified as a separate path from the writer
output/staging dirs, so I considered it as another temporary job-level
directory that has to be modified to work on the dataset-level. Hence why it
has to be added in cleanup here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
