Will-Lo commented on a change in pull request #3158:
URL: https://github.com/apache/gobblin/pull/3158#discussion_r596333265
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/JobLauncherUtils.java
##########
@@ -132,10 +132,9 @@ public static void cleanStagingData(List<? extends State>
states, Logger logger)
* @param logger a {@link Logger} used for logging
*/
public static void cleanJobStagingData(State state, Logger logger) throws
IOException {
-
Preconditions.checkArgument(state.contains(ConfigurationKeys.WRITER_STAGING_DIR),
- "Missing required property " + ConfigurationKeys.WRITER_STAGING_DIR);
-
Preconditions.checkArgument(state.contains(ConfigurationKeys.WRITER_OUTPUT_DIR),
- "Missing required property " + ConfigurationKeys.WRITER_OUTPUT_DIR);
+ if (!state.contains(ConfigurationKeys.WRITER_STAGING_DIR) ||
!state.contains(ConfigurationKeys.WRITER_OUTPUT_DIR)) {
Review comment:
This checks the job level state, not the workunit. So it would fail if
we do not specify the temporary directories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
