[
https://issues.apache.org/jira/browse/GOBBLIN-1437?focusedWorklogId=590113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590113
]
ASF GitHub Bot logged work on GOBBLIN-1437:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/21 02:10
Start Date: 28/Apr/21 02:10
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3268:
URL: https://github.com/apache/gobblin/pull/3268#issuecomment-825188703
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3268](https://codecov.io/gh/apache/gobblin/pull/3268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(37f5b2c) into
[master](https://codecov.io/gh/apache/gobblin/commit/0a504aa9acb2247002c9798cc5d5f2476513b183?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0a504aa) will **decrease** coverage by `37.46%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/gobblin/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3268 +/- ##
============================================
- Coverage 46.45% 8.99% -37.47%
+ Complexity 9992 1738 -8254
============================================
Files 2036 2037 +1
Lines 79180 79236 +56
Branches 8831 8834 +3
============================================
- Hits 36786 7126 -29660
- Misses 38973 71408 +32435
+ Partials 3421 702 -2719
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...a/org/apache/gobblin/runtime/api/SpecExecutor.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY0V4ZWN1dG9yLmphdmE=)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...a/org/apache/gobblin/runtime/api/SpecProducer.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY1Byb2R1Y2VyLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=)
| `42.79% <ø> (-9.53%)` | `19.00 <0.00> (-4.00)` | |
|
[...org/apache/gobblin/runtime/api/FsSpecConsumer.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0ZzU3BlY0NvbnN1bWVyLmphdmE=)
| `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-6.00)` | |
|
[...org/apache/gobblin/runtime/api/FsSpecProducer.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0ZzU3BlY1Byb2R1Y2VyLmphdmE=)
| `0.00% <0.00%> (-73.59%)` | `0.00 <0.00> (-9.00)` | |
|
[.../runtime/job\_catalog/NonObservingFSJobCatalog.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2NhdGFsb2cvTm9uT2JzZXJ2aW5nRlNKb2JDYXRhbG9nLmphdmE=)
| `0.00% <ø> (-55.82%)` | `0.00 <0.00> (-6.00)` | |
|
[...untime/job\_monitor/AvroJobSpecKafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvQXZyb0pvYlNwZWNLYWZrYUpvYk1vbml0b3IuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...n/runtime/job\_monitor/SLAEventKafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvU0xBRXZlbnRLYWZrYUpvYk1vbml0b3IuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [1094
more](https://codecov.io/gh/apache/gobblin/pull/3268/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[0a504aa...37f5b2c](https://codecov.io/gh/apache/gobblin/pull/3268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 590113)
Time Spent: 50m (was: 40m)
> Segregate FlowConfigs/Delete and FlowExecutions/Delete functions #3268
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1437
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1437
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> there are some mixup of work in FlowConfigs/Delete and FlowExecutions/Delete
> which is to be fixed
> FlowConfigs/Delete
> 1) is not cancelling the current running execution on cluster (i.e. when
> KafkaSpecProducer is used)
> 2) is not deleting state store when DagManager is used and KafkaSpecProducer
> is used
> FlowExecutions/Delete
> 1) is not calling SpecProducer.cancel()
> 2) is deleting the state store when KafkaSpecProducer is used, because
> cluster thinks it is a DELETE request
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
