[
https://issues.apache.org/jira/browse/GOBBLIN-1437?focusedWorklogId=590559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590559
]
ASF GitHub Bot logged work on GOBBLIN-1437:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/21 17:56
Start Date: 28/Apr/21 17:56
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3268:
URL: https://github.com/apache/gobblin/pull/3268#discussion_r622413513
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/job_catalog/NonObservingFSJobCatalog.java
##########
@@ -105,6 +105,14 @@ public synchronized void remove(URI jobURI) {
remove(jobURI, false);
}
+ /**
+ * Removes a job from job catalog.
+ * If it is a flow delete request from service side, then
alwaysTriggerListeners should be set to true so that a
+ * running job will also be cancelled. If it is a remove request because a
job finishes or has been submitted to helix,
+ * then alwaysTriggerListeners should be set to false so that job
cancellation is not triggered.
+ * @param jobURI job uri
+ * @param alwaysTriggerListeners if it is true, a running job will be
cancelled.
Review comment:
called the cancel on spec catalog listeners directly from job monitor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 590559)
Time Spent: 1h 10m (was: 1h)
> Segregate FlowConfigs/Delete and FlowExecutions/Delete functions #3268
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1437
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1437
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> there are some mixup of work in FlowConfigs/Delete and FlowExecutions/Delete
> which is to be fixed
> FlowConfigs/Delete
> 1) is not cancelling the current running execution on cluster (i.e. when
> KafkaSpecProducer is used)
> 2) is not deleting state store when DagManager is used and KafkaSpecProducer
> is used
> FlowExecutions/Delete
> 1) is not calling SpecProducer.cancel()
> 2) is deleting the state store when KafkaSpecProducer is used, because
> cluster thinks it is a DELETE request
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
