sv2000 commented on a change in pull request #3272:
URL: https://github.com/apache/gobblin/pull/3272#discussion_r627835999
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -372,16 +372,17 @@ public synchronized void setActive(boolean active) {
//Initializing state store for persisting Dags.
this.dagStateStore = createDagStateStore(config, topologySpecMap);
this.failedDagStateStore =
createDagStateStore(ConfigUtils.getConfigOrEmpty(config,
FAILED_DAG_STATESTORE_PREFIX).withFallback(config), topologySpecMap);
+ Set<String> failedDagIds =
Collections.synchronizedSet(this.failedDagStateStore.getDagIds());
Review comment:
Can we not look up a dag with a given dagId from the dagStateStore when
a resume is called? (which should be infrequent), instead of loading dagIds on
start up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
