jack-moseley commented on a change in pull request #3272:
URL: https://github.com/apache/gobblin/pull/3272#discussion_r627837492
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -372,16 +372,17 @@ public synchronized void setActive(boolean active) {
//Initializing state store for persisting Dags.
this.dagStateStore = createDagStateStore(config, topologySpecMap);
this.failedDagStateStore =
createDagStateStore(ConfigUtils.getConfigOrEmpty(config,
FAILED_DAG_STATESTORE_PREFIX).withFallback(config), topologySpecMap);
+ Set<String> failedDagIds =
Collections.synchronizedSet(this.failedDagStateStore.getDagIds());
Review comment:
That is what I am doing, see the changes in `beginResumingDag` just
below this. The reason for still keeping this list is that it's used to know
which dags are old enough to delete from the failed dag state store, and also
it could avoid some calls to mysql (if calling resume with an invalid dag). The
list of dagIds is only strings so it shouldn't be large in memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
