[
https://issues.apache.org/jira/browse/GOBBLIN-1448?focusedWorklogId=601368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601368
]
ASF GitHub Bot logged work on GOBBLIN-1448:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/21 20:00
Start Date: 24/May/21 20:00
Worklog Time Spent: 10m
Work Description: aplex commented on a change in pull request #3286:
URL: https://github.com/apache/gobblin/pull/3286#discussion_r638237543
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -598,7 +598,7 @@ public void apply(JobListener jobListener, JobContext
jobContext)
}
});
- if (jobState.getState() == JobState.RunningState.FAILED) {
+ if (jobState.getState() == JobState.RunningState.FAILED ||
jobState.getState() == JobState.RunningState.CANCELLED) {
Review comment:
Is there another bug in "else" branch below? It creates a
"JOB_SUCCEEDED" event, but the listener is calling "onJobFailure" event. Also
the same logic is a coupe of blocks above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601368)
Time Spent: 20m (was: 10m)
> Send failed timer instead of success timer when job is cancelled
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1448
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1448
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
