[
https://issues.apache.org/jira/browse/GOBBLIN-1448?focusedWorklogId=601396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601396
]
ASF GitHub Bot logged work on GOBBLIN-1448:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/21 20:47
Start Date: 24/May/21 20:47
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3286:
URL: https://github.com/apache/gobblin/pull/3286#discussion_r638260887
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -598,7 +598,7 @@ public void apply(JobListener jobListener, JobContext
jobContext)
}
});
- if (jobState.getState() == JobState.RunningState.FAILED) {
+ if (jobState.getState() == JobState.RunningState.FAILED ||
jobState.getState() == JobState.RunningState.CANCELLED) {
Review comment:
It's been like that for a long time, I'm not sure if that was originally
intentional or not. But there is no `onJobSuccess` API, so I'm not sure what
would replace it. Also would have to be careful changing something here, since
changing logic could affect many gobblin jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601396)
Time Spent: 0.5h (was: 20m)
> Send failed timer instead of success timer when job is cancelled
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1448
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1448
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
