[
https://issues.apache.org/jira/browse/GOBBLIN-1479?focusedWorklogId=614157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614157
]
ASF GitHub Bot logged work on GOBBLIN-1479:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/21 18:23
Start Date: 23/Jun/21 18:23
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3319:
URL: https://github.com/apache/gobblin/pull/3319#discussion_r657360705
##########
File path:
gobblin-modules/gobblin-sql/src/main/java/org/apache/gobblin/source/jdbc/JdbcExtractor.java
##########
@@ -959,6 +959,10 @@ public long getCount(CommandOutput<?, ?> response) throws
RecordCountException {
int batchSize =
this.workUnitState.getPropAsInt(ConfigurationKeys.SOURCE_QUERYBASED_FETCH_SIZE,
0);
batchSize = (batchSize == 0 ?
ConfigurationKeys.DEFAULT_SOURCE_FETCH_SIZE : batchSize);
+ String sourceConnProps =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_PROPERTIES);
+ boolean convertZeroDateTimeToNull = sourceConnProps != null
Review comment:
I think here we can generalize this a bit more rather than keep it only
to the zeroDateTime behavior, to support the other zeroDateTime properties if
there are any users. We can check that sourceConnProps contains
zeroDateTimeBehavior, then parse it as timestamp and return the result. This
way it can handle the `ROUND` case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 614157)
Time Spent: 20m (was: 10m)
> MySQL Extractor does not respect zeroDateTime configurations
> ------------------------------------------------------------
>
> Key: GOBBLIN-1479
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1479
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When adding connectionUrl properties for zeroDateTime, it is not respected by
> the MySQL 8 connector as the timestamp is parsed as a String, thus returning
> the zero timestamp instead of the behavior denoted by the property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
