[
https://issues.apache.org/jira/browse/GOBBLIN-1479?focusedWorklogId=614255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614255
]
ASF GitHub Bot logged work on GOBBLIN-1479:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/21 22:49
Start Date: 23/Jun/21 22:49
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3319:
URL: https://github.com/apache/gobblin/pull/3319#issuecomment-867208132
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3319](https://codecov.io/gh/apache/gobblin/pull/3319?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a3656e4) into
[master](https://codecov.io/gh/apache/gobblin/commit/00eb1f79dbdd4bc562a76867db0c47928fa4aeaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(00eb1f7) will **increase** coverage by `3.41%`.
> The diff coverage is `55.22%`.
[](https://codecov.io/gh/apache/gobblin/pull/3319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3319 +/- ##
============================================
+ Coverage 45.61% 49.03% +3.41%
+ Complexity 8970 8564 -406
============================================
Files 1902 1652 -250
Lines 71296 63586 -7710
Branches 7862 7312 -550
============================================
- Hits 32522 31178 -1344
+ Misses 35781 29453 -6328
+ Partials 2993 2955 -38
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...org/apache/gobblin/commit/CommitStepException.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29tbWl0L0NvbW1pdFN0ZXBFeGNlcHRpb24uamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...n/java/org/apache/gobblin/configuration/State.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9TdGF0ZS5qYXZh)
| `32.60% <ø> (+4.34%)` | :arrow_up: |
|
[...n/java/org/apache/gobblin/converter/Converter.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL0NvbnZlcnRlci5qYXZh)
| `74.35% <ø> (ø)` | |
|
[.../org/apache/gobblin/dataset/FileSystemDataset.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9GaWxlU3lzdGVtRGF0YXNldC5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...va/org/apache/gobblin/publisher/DataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcHVibGlzaGVyL0RhdGFQdWJsaXNoZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[.../gobblin/runtime/CheckpointableWatermarkState.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9DaGVja3BvaW50YWJsZVdhdGVybWFya1N0YXRlLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[...obblin/runtime/NoopTaskEventMetadataGenerator.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9Ob29wVGFza0V2ZW50TWV0YWRhdGFHZW5lcmF0b3IuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...a/org/apache/gobblin/runtime/api/SpecExecutor.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY0V4ZWN1dG9yLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[...a/org/apache/gobblin/runtime/api/SpecProducer.java](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY1Byb2R1Y2VyLmphdmE=)
| `0.00% <0.00%> (ø)` | |
| ... and [842
more](https://codecov.io/gh/apache/gobblin/pull/3319/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3319?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3319?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[5f39339...a3656e4](https://codecov.io/gh/apache/gobblin/pull/3319?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 614255)
Time Spent: 1h (was: 50m)
> MySQL Extractor does not respect zeroDateTime configurations
> ------------------------------------------------------------
>
> Key: GOBBLIN-1479
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1479
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When adding connectionUrl properties for zeroDateTime, it is not respected by
> the MySQL 8 connector as the timestamp is parsed as a String, thus returning
> the zero timestamp instead of the behavior denoted by the property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
