[
https://issues.apache.org/jira/browse/GOBBLIN-1480?focusedWorklogId=614215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614215
]
ASF GitHub Bot logged work on GOBBLIN-1480:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/21 20:35
Start Date: 23/Jun/21 20:35
Worklog Time Spent: 10m
Work Description: aplex opened a new pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320
Previously, checkstyle was configured to check only a small subset of
things, and imports were not one of them. As a result, reviewers spend
their time commenting on code style, when it can be fully verified
automatically by CI job.
We enable unused/redundant import checks, and fix existing issues, so
that the build could complete successfully.
The only relevant change is in checkstyle.xml, all other files where
changed by IntelliJ "optimize imports" function. For most files it
just removed unused imports, but some of them had imports incorrectly
ordered, and IntelliJ fixed that as well.
https://issues.apache.org/jira/browse/GOBBLIN-1480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 614215)
Remaining Estimate: 0h
Time Spent: 10m
> Cleanup unused imports and enable code style checks for them
> ------------------------------------------------------------
>
> Key: GOBBLIN-1480
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1480
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Alex Prokofiev
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, checkstyle was configured to check only a small subset of things,
> and imports were not one of them. As a result, reviewers spend their time
> commenting on code style, when it can be fully verified automatically by CI
> job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
