[
https://issues.apache.org/jira/browse/GOBBLIN-1480?focusedWorklogId=617255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617255
]
ASF GitHub Bot logged work on GOBBLIN-1480:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/21 20:07
Start Date: 30/Jun/21 20:07
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-867154244
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3320](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a25b304) into
[master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(bf37c76) will **decrease** coverage by `0.18%`.
> The diff coverage is `76.47%`.
[](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3320 +/- ##
============================================
- Coverage 46.50% 46.32% -0.19%
+ Complexity 10041 3047 -6994
============================================
Files 2041 642 -1399
Lines 79349 25000 -54349
Branches 8845 2985 -5860
============================================
- Hits 36898 11580 -25318
+ Misses 39020 12172 -26848
+ Partials 3431 1248 -2183
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...n/java/org/apache/gobblin/cli/CliTablePrinter.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvQ2xpVGFibGVQcmludGVyLmphdmE=)
| `0.00% <ø> (ø)` | |
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <ø> (ø)` | |
|
[...a/org/apache/gobblin/password/PasswordManager.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcGFzc3dvcmQvUGFzc3dvcmRNYW5hZ2VyLmphdmE=)
| `28.28% <ø> (ø)` | |
|
[...org/apache/gobblin/typedconfig/ConstraintUtil.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZWRjb25maWcvQ29uc3RyYWludFV0aWwuamF2YQ==)
| `0.00% <ø> (ø)` | |
|
[...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=)
| `0.00% <ø> (ø)` | |
|
[.../gobblin/cluster/GobblinClusterMetricTagNames.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNZXRyaWNUYWdOYW1lcy5qYXZh)
| `0.00% <ø> (ø)` | |
|
[...pache/gobblin/cluster/GobblinHelixTaskMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza01ldHJpY3MuamF2YQ==)
| `97.61% <ø> (ø)` | |
|
[...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==)
| `100.00% <ø> (ø)` | |
|
[...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=)
| `0.00% <ø> (ø)` | |
|
[.../store/hdfs/SimpleLocalHDFSConfigStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9oZGZzL1NpbXBsZUxvY2FsSERGU0NvbmZpZ1N0b3JlRmFjdG9yeS5qYXZh)
| `60.00% <ø> (ø)` | |
| ... and [1329
more](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[1e03329...a25b304](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617255)
Time Spent: 40m (was: 0.5h)
> Cleanup unused imports and enable code style checks for them
> ------------------------------------------------------------
>
> Key: GOBBLIN-1480
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1480
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Alex Prokofiev
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, checkstyle was configured to check only a small subset of things,
> and imports were not one of them. As a result, reviewers spend their time
> commenting on code style, when it can be fully verified automatically by CI
> job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
