[
https://issues.apache.org/jira/browse/GOBBLIN-1475?focusedWorklogId=614239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614239
]
ASF GitHub Bot logged work on GOBBLIN-1475:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/21 21:45
Start Date: 23/Jun/21 21:45
Worklog Time Spent: 10m
Work Description: umustafi commented on a change in pull request #3314:
URL: https://github.com/apache/gobblin/pull/3314#discussion_r657483057
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -217,6 +218,32 @@ private static void
modifyStateIfRetryRequired(org.apache.gobblin.configuration.
return new org.apache.gobblin.configuration.State(mergedState);
}
+ /**
+ * Events with different `currentAttempts` may arrive out of order and we
should use the max of both the counts to
+ * set the new value of `currentAttempts`. However, when a flow is resumed,
it sends an event with count=0 and at that
+ * time, we should update it to zero. Because events can arrive out of
order, we must do this only when the event with
Review comment:
what does the count 0 here indicate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 614239)
Remaining Estimate: 0h
Time Spent: 10m
> merge `currentAttempts` correctly when processing out of order tracking events
> ------------------------------------------------------------------------------
>
> Key: GOBBLIN-1475
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1475
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
