aplex commented on a change in pull request #3330:
URL: https://github.com/apache/gobblin/pull/3330#discussion_r669873661
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
##########
@@ -969,6 +970,7 @@
public static final Charset DEFAULT_CHARSET_ENCODING = Charsets.UTF_8;
public static final String TEST_HARNESS_LAUNCHER_IMPL =
"gobblin.testharness.launcher.impl";
public static final int PERMISSION_PARSING_RADIX = 8;
+ public static final String NON_TRANSIENT_ERROR_MESSAGES =
"non.transient.error.messages";
Review comment:
Also, you can add a purpose of this setting as a javadoc comment. I see
that you included it in the commit message, but having it in code can be
beneficial too, if people look at the list of settings and try to find out what
they mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]