arjun4084346 commented on a change in pull request #3330:
URL: https://github.com/apache/gobblin/pull/3330#discussion_r669903549
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
##########
@@ -969,6 +970,7 @@
public static final Charset DEFAULT_CHARSET_ENCODING = Charsets.UTF_8;
public static final String TEST_HARNESS_LAUNCHER_IMPL =
"gobblin.testharness.launcher.impl";
public static final int PERMISSION_PARSING_RADIX = 8;
+ public static final String NON_TRANSIENT_ERROR_MESSAGES =
"non.transient.error.messages";
Review comment:
It can be either. Sometimes, the exception class is very generic, e.g.
IOException, in that case this config can include error message also.
It all depends how to value of this config is being used. in li-gobblin, I
compare it with exception.getMessage() which contains both class and message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
