[
https://issues.apache.org/jira/browse/GOBBLIN-1507?focusedWorklogId=635465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635465
]
ASF GitHub Bot logged work on GOBBLIN-1507:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 19:50
Start Date: 06/Aug/21 19:50
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3353:
URL: https://github.com/apache/gobblin/pull/3353#discussion_r684470352
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -347,6 +343,30 @@ public AddSpecResponse onAddSpec(Spec addedSpec) {
return new AddSpecResponse<>(response);
}
+ /**
+ * Remove a flowSpec from schedule due to another leader being elected
+ * Unlike onDeleteSpec, we want to avoid deleting the flowSpec on the
executor
+ * and we still want to unschedule if we cannot connect to zookeeper as the
current node cannot be the master
+ * @param specURI
+ * @param specVersion
+ */
+ private void unscheduleSpec(URI specURI, String specVersion) {
Review comment:
onDeleteSpec also checks for connection to zookeeper though, and I think
that's a bad check if the host is demoted. If a host that used to be master
gets demoted, it's likely struggling with connectivity so unscheduleSpec
handles that.
@arjun4084346 can do that too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 635465)
Time Spent: 1.5h (was: 1h 20m)
> GaaS job scheduler removes flowSpecs on unscheduling
> ----------------------------------------------------
>
> Key: GOBBLIN-1507
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1507
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When demoted from leader, GaaS removes all flows from orchestrator. We need
> to ensure that fail over events are not disruptive or destructive to
> currently running flows, we only want the new leader node to handle
> scheduling responsibilities from that point forward.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)