[
https://issues.apache.org/jira/browse/GOBBLIN-1507?focusedWorklogId=636155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636155
]
ASF GitHub Bot logged work on GOBBLIN-1507:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/21 23:13
Start Date: 09/Aug/21 23:13
Worklog Time Spent: 10m
Work Description: aplex commented on a change in pull request #3353:
URL: https://github.com/apache/gobblin/pull/3353#discussion_r685518098
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -74,8 +61,17 @@
import org.apache.gobblin.service.monitoring.FlowStatusGenerator;
import org.apache.gobblin.util.ConfigUtils;
import org.apache.gobblin.util.PropertiesUtils;
+import org.apache.helix.HelixManager;
+import org.quartz.DisallowConcurrentExecution;
+import org.quartz.InterruptableJob;
+import org.quartz.JobDataMap;
+import org.quartz.JobExecutionContext;
+import org.quartz.JobExecutionException;
+import org.quartz.UnableToInterruptJobException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
-import static
org.apache.gobblin.service.ServiceConfigKeys.GOBBLIN_SERVICE_PREFIX;
+import static org.apache.gobblin.service.ServiceConfigKeys.*;
Review comment:
Wildcard imports are risky -
https://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad
The only place were we typically use them is in assertions/mock import, to
improve test readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 636155)
Time Spent: 2h 40m (was: 2.5h)
> GaaS job scheduler removes flowSpecs on unscheduling
> ----------------------------------------------------
>
> Key: GOBBLIN-1507
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1507
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> When demoted from leader, GaaS removes all flows from orchestrator. We need
> to ensure that fail over events are not disruptive or destructive to
> currently running flows, we only want the new leader node to handle
> scheduling responsibilities from that point forward.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)