[
https://issues.apache.org/jira/browse/GOBBLIN-1510?focusedWorklogId=636179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636179
]
ASF GitHub Bot logged work on GOBBLIN-1510:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/21 00:06
Start Date: 10/Aug/21 00:06
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3358:
URL: https://github.com/apache/gobblin/pull/3358#discussion_r685596475
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResourceLocalHandler.java
##########
@@ -215,15 +216,18 @@ private static long
getFlowStartTime(org.apache.gobblin.service.monitoring.FlowS
* @param completionPercentage of the job
* @return time left in seconds
Review comment:
should be time in string format
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskStateCollectorService.java
##########
@@ -281,7 +280,8 @@ private void reportJobProgress(TaskState taskState) {
this.bytesCopiedSoFar += taskByteSize;
Double newPercentageCopied = this.bytesCopiedSoFar / this.totalSizeToCopy;
- if (newPercentageCopied - this.lastPercentageReported >
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD) {
+ if (newPercentageCopied - this.lastPercentageReported >=
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD ||
+ (newPercentageCopied > 1 -
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD &&
Math.abs(newPercentageCopied - this.lastPercentageReported) > 0.001)) {
Review comment:
Let's leave a comment here for what this second scenario covers. Even
though it's when the job is going from 95-100%, would 0.001 be a bit low of a
threshold? It'll send up to 50 events reporting from 95-100 for each job, which
seems a quite different from the previous reporting thresholds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 636179)
Time Spent: 1h 20m (was: 1h 10m)
> Fix Progress Reporting Behavior & Cleanup Logs
> ----------------------------------------------
>
> Key: GOBBLIN-1510
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1510
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core, gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> # Currently, when a job approaches the end the progress can appear "stuck" at
> 96-99% because the progress changes are only reported if they are larger than
> the threshold (5%).
> # Decrease number of logs
> # Format the estimated time left to be human readable "X hours Y min Z
> seconds" rather than "40389 seconds"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)