[ 
https://issues.apache.org/jira/browse/GOBBLIN-1510?focusedWorklogId=636186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636186
 ]

ASF GitHub Bot logged work on GOBBLIN-1510:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/21 00:23
            Start Date: 10/Aug/21 00:23
    Worklog Time Spent: 10m 
      Work Description: umustafi commented on a change in pull request #3358:
URL: https://github.com/apache/gobblin/pull/3358#discussion_r685605606



##########
File path: 
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskStateCollectorService.java
##########
@@ -281,7 +280,8 @@ private void reportJobProgress(TaskState taskState) {
     this.bytesCopiedSoFar += taskByteSize;
     Double newPercentageCopied = this.bytesCopiedSoFar / this.totalSizeToCopy;
 
-    if (newPercentageCopied - this.lastPercentageReported > 
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD) {
+    if (newPercentageCopied - this.lastPercentageReported >= 
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD ||
+        (newPercentageCopied > 1 - 
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD && 
Math.abs(newPercentageCopied - this.lastPercentageReported) > 0.001)) {

Review comment:
       Agree with the points above. It's a choice essentially between if we 
want to report 96, 97, 98, 99, and 100 potentially or just report 95 and then 
100. I did 0.001 as the threshold in case the 0.1% difference corresponds to 
the number being rounded up, but I did think it could be excessive like you are 
saying in the worst case. Any preferences? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 636186)
    Time Spent: 1h 40m  (was: 1.5h)

> Fix Progress Reporting Behavior & Cleanup Logs
> ----------------------------------------------
>
>                 Key: GOBBLIN-1510
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1510
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-core, gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> # Currently, when a job approaches the end the progress can appear "stuck" at 
> 96-99% because the progress changes are only reported if they are larger than 
> the threshold (5%).
>  # Decrease number of logs 
>  # Format the estimated time left to be human readable "X hours Y min Z 
> seconds" rather than "40389 seconds"  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to