ZihanLi58 opened a new pull request #3364:
URL: https://github.com/apache/gobblin/pull/3364


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1515
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   There are two issues need to be fixed:
   
   1. Fix the issue that Hive schema is using avro schema even for orc table: 
Now, since we directly use avro schema literal to calculate the column and 
column types for orc table, it sometimes is not correct, so we need to change 
avro schema to orc schema and compute column types accordingly
   
   2. Change the behavior that we only evolve avro schema literal but not the 
hive schema when schema evolution happen: In Streaming, when we do hive 
registration, we compare the current schema with schema registry and when there 
is schema evolution, we only update avro schema literal and leave hive schema 
to be lag. 
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to