autumnust commented on a change in pull request #3364:
URL: https://github.com/apache/gobblin/pull/3364#discussion_r688677498
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##########
@@ -270,13 +271,11 @@ private void addSchemaProperties(Path path,
HiveRegistrationUnit hiveUnit)
*/
protected void addSchemaPropertiesHelper(Path path, HiveRegistrationUnit
hiveUnit) throws IOException {
TypeInfo schema;
-
if(!Strings.isNullOrEmpty(props.getProp(AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getPropName())))
{
- try {
- Schema avroSchema = new
Schema.Parser().parse(props.getProp(AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getPropName()));
- schema = TypeInfoUtils.getTypeInfoFromObjectInspector(new
AvroObjectInspectorGenerator(avroSchema).getObjectInspector());
- } catch (SerDeException e) {
- throw new IOException(e);
- }
+ String schemaString =
hiveUnit.getSerDeProps().getProp(AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getPropName(),
props.getProp(AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getPropName()));
Review comment:
this line is too long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]