[
https://issues.apache.org/jira/browse/GOBBLIN-1515?focusedWorklogId=637879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637879
]
ASF GitHub Bot logged work on GOBBLIN-1515:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/21 19:44
Start Date: 13/Aug/21 19:44
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3364:
URL: https://github.com/apache/gobblin/pull/3364#discussion_r688743116
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java
##########
@@ -421,6 +425,19 @@ private static Deserializer
getDeserializer(HiveRegistrationUnit unit) {
return deserializer;
}
+ public static void updateColumnsInfo(HiveSpec spec) throws IOException {
+ HiveTable table = spec.getTable();
+ if (table.getSerDeProps().contains(serdeConstants.LIST_COLUMNS)) {
+ if (table.getSerDeManager().isPresent()) {
+ String path = spec.getPartition().isPresent() &&
spec.getPartition().get().getLocation().isPresent() ? spec.getPartition()
Review comment:
Yeah, in OrcSerDeManager, if no avro shcema literal is set, it will try
to list the path to get the latest file's schema, even it's not gonna to happen
in our case, just want to make sure the list operation is as small as possible
even something goes wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 637879)
Time Spent: 2.5h (was: 2h 20m)
> Fix hive schema not updated issue in streaming and GMIP
> -------------------------------------------------------
>
> Key: GOBBLIN-1515
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1515
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> There are two issues need to be fixed:
> 1. Fix the issue that Hive schema is using avro schema even for orc table:
> Now, since we directly use avro schema literal to calculate the column and
> column types for orc table, it sometimes is not correct, so we need to change
> avro schema to orc schema and compute column types accordingly
> 2. Change the behavior that we only evolve avro schema literal but not the
> hive schema when schema evolution happen: In Streaming, when we do hive
> registration, we compare the current schema with schema registry and when
> there is schema evolution, we only update avro schema literal and leave hive
> schema to be lag.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)