[
https://issues.apache.org/jira/browse/GOBBLIN-1515?focusedWorklogId=638442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-638442
]
ASF GitHub Bot logged work on GOBBLIN-1515:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/21 23:38
Start Date: 16/Aug/21 23:38
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3364:
URL: https://github.com/apache/gobblin/pull/3364#issuecomment-898093924
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3364](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(40a887f) into
[master](https://codecov.io/gh/apache/gobblin/commit/48af4c61c4780740b63931901c756e5a184e763b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(48af4c6) will **decrease** coverage by `0.12%`.
> The diff coverage is `7.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3364 +/- ##
============================================
- Coverage 46.54% 46.41% -0.13%
- Complexity 10136 10143 +7
============================================
Files 2051 2056 +5
Lines 79547 80076 +529
Branches 8880 8943 +63
============================================
+ Hits 37027 37171 +144
- Misses 39091 39456 +365
- Partials 3429 3449 +20
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...apache/gobblin/hive/writer/HiveMetadataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL3dyaXRlci9IaXZlTWV0YWRhdGFXcml0ZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...l/io/orc/TypeDescriptionToObjectInspectorUtil.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hpdmUvcWwvaW8vb3JjL1R5cGVEZXNjcmlwdGlvblRvT2JqZWN0SW5zcGVjdG9yVXRpbC5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...org/apache/gobblin/iceberg/GobblinMCEProducer.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvR29iYmxpbk1DRVByb2R1Y2VyLmphdmE=)
| `48.71% <0.00%> (-1.29%)` | :arrow_down: |
|
[.../gobblin/writer/GenericRecordToOrcValueWriter.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9HZW5lcmljUmVjb3JkVG9PcmNWYWx1ZVdyaXRlci5qYXZh)
| `59.66% <ø> (ø)` | |
|
[...va/org/apache/gobblin/writer/GobblinOrcWriter.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Hb2JibGluT3JjV3JpdGVyLmphdmE=)
| `41.66% <ø> (ø)` | |
|
[...pache/gobblin/util/orc/AvroOrcSchemaConverter.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvb3JjL0F2cm9PcmNTY2hlbWFDb252ZXJ0ZXIuamF2YQ==)
| `58.33% <ø> (ø)` | |
|
[...che/gobblin/hive/metastore/HiveMetaStoreUtils.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlVXRpbHMuamF2YQ==)
| `46.35% <22.22%> (-0.97%)` | :arrow_down: |
|
[...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh)
| `10.69% <50.00%> (+0.21%)` | :arrow_up: |
|
[...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=)
| `60.41% <58.82%> (+0.63%)` | :arrow_up: |
|
[...blin/data/management/copy/RecursivePathFinder.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvUmVjdXJzaXZlUGF0aEZpbmRlci5qYXZh)
| `0.00% <0.00%> (-92.31%)` | :arrow_down: |
| ... and [67
more](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[48af4c6...40a887f](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 638442)
Time Spent: 2h 50m (was: 2h 40m)
> Fix hive schema not updated issue in streaming and GMIP
> -------------------------------------------------------
>
> Key: GOBBLIN-1515
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1515
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> There are two issues need to be fixed:
> 1. Fix the issue that Hive schema is using avro schema even for orc table:
> Now, since we directly use avro schema literal to calculate the column and
> column types for orc table, it sometimes is not correct, so we need to change
> avro schema to orc schema and compute column types accordingly
> 2. Change the behavior that we only evolve avro schema literal but not the
> hive schema when schema evolution happen: In Streaming, when we do hive
> registration, we compare the current schema with schema registry and when
> there is schema evolution, we only update avro schema literal and leave hive
> schema to be lag.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)