srramach commented on a change in pull request #3328:
URL: https://github.com/apache/gobblin/pull/3328#discussion_r689227129
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/converter/avro/JsonElementConversionFactory.java
##########
@@ -617,9 +618,12 @@ private Schema buildRecordSchema(JsonSchema schema,
WorkUnitState workUnit, Stri
} catch (UnsupportedDateTypeException e) {
throw new UnsupportedOperationException(e);
}
-
- Schema.Field fld = new Schema.Field(map.getColumnName(), fldSchema,
map.getComment(),
- map.isNullable() ? JsonNodeFactory.instance.nullNode() : null);
+ // TODO - Fix this. The "map" variable is of type JsonSchema (Gobblin
internal
+ // implementation). For map.isNullable,
AvroCompatibilityUtils.NULL_VALUE is passed. For
+ // non null, identify the exact change. As curently null is passed,
+ // JsonElementConversionFactoryTest is failing.
Review comment:
> As curently null is passed, JsonElementConversionFactoryTest is
failing.
When map.isNullable() is false, even the previous code was passing null, so
there doesn't seem to be any change in that respect. So why does the test fail
now, but didn't before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
