srramach commented on a change in pull request #3328: URL: https://github.com/apache/gobblin/pull/3328#discussion_r689230873
########## File path: gobblin-utility/src/main/java/org/apache/gobblin/util/AvroCompatibilityUtils.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.util; + +import com.linkedin.avroutil1.compatibility.AvroCompatibilityHelper; +import com.linkedin.avroutil1.compatibility.AvroVersion; +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import org.apache.avro.JsonProperties; +import org.apache.avro.Schema; +import org.codehaus.jackson.JsonNode; +import org.codehaus.jackson.node.BooleanNode; +import org.codehaus.jackson.node.DoubleNode; +import org.codehaus.jackson.node.IntNode; +import org.codehaus.jackson.node.LongNode; +import org.codehaus.jackson.node.NullNode; +import org.codehaus.jackson.node.TextNode; + + +/** + * The purpose of this helper class is to make some avro API portable across difference versions of avro. + * Once all the consumers of Gobblin core library is migrated to Avro 1.9.2, this class can be + * removed. + * See also {@link com.linkedin.avroutil1.compatibility.AvroCompatibilityHelper} Review comment: Why not use the AvroComaptibilityHelper directly? Why make a wrapper around it? I am sure you have good reasons; could you please explain some of them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
